Refactor WriterOptions processConfigs function#10762
Refactor WriterOptions processConfigs function#10762kewang1024 wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D61304850 |
|
This pull request was exported from Phabricator. Differential Revision: D61304850 |
kewang1024
force-pushed
the
export-D61304850
branch
from
0aadd43 to
1195adf
Compare
xiaoxmeng
left a comment
xiaoxmeng
left a comment
There was a problem hiding this comment.
@kewang1024 thanks for working on this. Make sure the test all pass before land. Thanks!
There was a problem hiding this comment.
Consider to move the connector and session properties init into this function? Thanks!
|
This pull request was exported from Phabricator. Differential Revision: D61304850 |
kewang1024
force-pushed
the
export-D61304850
branch
from
1195adf to
d6369c0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61304850 |
kewang1024
force-pushed
the
export-D61304850
branch
from
d6369c0 to
4fb4e98
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61304850 |
kewang1024
force-pushed
the
export-D61304850
branch
from
4fb4e98 to
92a1b93
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61304850 |
kewang1024
force-pushed
the
export-D61304850
branch
from
92a1b93 to
d840da2
Compare
kewang1024
force-pushed
the
export-D61304850
branch
from
d840da2 to
7213049
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61304850 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D61304850 |
kewang1024
force-pushed
the
export-D61304850
branch
from
7213049 to
2b28627
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61304850 |
kewang1024
force-pushed
the
export-D61304850
branch
from
2b28627 to
f324dc5
Compare
Summary: Pull Request resolved: facebookincubator#10762 Merge processSessionConfigs and processHiveConnectorConfigs as one function processConfigs. In processConfigs(), it prioritize getting config from session property, if not found, use config from connector config. Reviewed By: xiaoxmeng Differential Revision: D61304850
kewang1024
force-pushed
the
export-D61304850
branch
from
f324dc5 to
36d5f19
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61304850 |
|
This pull request has been merged in 54b16e0. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
4 participants
Summary:
Merge processSessionConfigs and processHiveConnectorConfigs
as one function processConfigs.
In processConfigs(), it prioritize getting config from session property,
if not found, use config from connector config.
Differential Revision: D61304850